Call self_closing_tags only once on raw_html #517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self_closing_tags
is not a slow function, but today it is called thousands of times while generating the raw html, which ends up causing a significant performance impact.This PR modifies the RawHTML module to call
self_closing_tags()
only once onraw_html
, sending the value as params to the other functions.raw_html
also converts closing tags to MapSet to help speed up the check .