Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We finally got to this PR, after all of the preparation PRs.
With this PR changes, we'll check if we can run the search directly in the raw html nodes instead of building an html tree. To keep it simple for now, this will be applied only if find is called with a single selector that is not a composite selector nor uses pseudo-classes.
Composite selectors will require some more work, but it looks possible to do. Some pseudo-classes don't require the tree and should be easy to enable, like
:disabled
, but the other pseudo-classes will be a lot more complicated, and will require some investigation to see how hard it would be to implement them.Benchmark results are a lot better than I expected, specially on big documents.