Support countdown via notification #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, switched from `notify-send` to `gdbus` as the former doesn't seem to allow replacing existing notifications with a new one.
|
Very cool! I'll have to setup a notification daemon to test this properly, since i don't have one rn. But i'll get to it as soon as i find some time! |
phisch
requested changes
Apr 26, 2023
There was a problem hiding this comment.
Well, I'm sorry for sitting on this for ages. I never setup a notification daemon, and now even switched away from x11. I'd still love to add this for other users if the few comments are addressed. If this and #26 are merged, I'd make a new release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14. I've switched the
notifyfunction to usegdbusinstead ofnotify-sendsince the latter doesn't seem to support replacing/closing existing notifications.