New testing module #774
Merged
New testing module #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldrapper
commented
Sep 7, 2024
Comment on lines
+9
to
+17
| if defined?(Minitest::Test) && Minitest::Test > mod | ||
| require "capybara/minitest" | ||
| include Capybara::Minitest::Assertions | ||
| end | ||
|
|
||
| if defined?(RSpec::Core::ExampleGroup) && RSpec::Core::ExampleGroup > mod | ||
| require "capybara/rspec" | ||
| include Capybara::RSpecMatchers | ||
| end |
There was a problem hiding this comment.
Automatically detect which testing framework you’re using an include relevant matchers / assertions.
joeldrapper
commented
Sep 7, 2024
Comment on lines
+20
to
+21
| attr_reader :page | ||
| alias_method :component, :page |
There was a problem hiding this comment.
We need to have page for the built in capybara matchers, but you may want to refer to it as component.
joeldrapper
commented
Sep 7, 2024
Comment on lines
+8
to
+18
| def render_fragment(...) | ||
| ::Nokogiri::HTML5.fragment( | ||
| render_to_string(...), | ||
| ) | ||
| end | ||
|
|
||
| def render_document(...) | ||
| ::Nokogiri::HTML5( | ||
| render_to_string(...), | ||
| ) | ||
| end |
There was a problem hiding this comment.
In Nokogiri and Nokolexbor, you need to specify if you’re rendering a document or a fragment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new testing module to replace the external gems
phlex-testing-capybaraandphlex-testing-nokogiri.