Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

srcdoc should be considered unsafe in version of Phlex that don’t escape attribute values #777

Merged
merged 1 commit into from
Sep 12, 2024
Merged

srcdoc should be considered unsafe in version of Phlex that don’t escape attribute values #777

merged 1 commit into from
Sep 12, 2024

Conversation

joeldrapper
Copy link
Collaborator

Since we replaced the HTML escape with a " gsub, we should consider srcdoc unsafe.

@joeldrapper joeldrapper marked this pull request as ready for review September 12, 2024 09:48
@joeldrapper joeldrapper merged commit b0694c7 into main Sep 12, 2024
6 checks passed
@joeldrapper joeldrapper deleted the srcdoc-unsafe branch September 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joeldrapper