Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path to correct layout template in 'Channels' guide and socket.js template #5704

Conversation

thisistonydang
Copy link
Contributor

The guide for Channels and the socket.js template generated by phx.gen.socket suggest to add the user token in app.html.heex:

// lib/hello_web/components/layouts/app.html.heex

<script>window.userToken = "<%= assigns[:user_token] %>";</script>
<script src={~p"/assets/app.js"}></script>

However, in the latest Phoenix, the app.js script is now located in root.html.heex. This PR updates the guide and template to point to the root.html.heex template.

@SteffenDE SteffenDE merged commit 2875c54 into phoenixframework:main Dec 1, 2024
5 of 7 checks passed
@SteffenDE
Copy link
Contributor

Thank you! 🙌🏻

@thisistonydang thisistonydang deleted the tonydangblog/update-layout-path branch December 4, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants