Update deps & fix otp26 tests #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 21, 2023
josevalim
approved these changes
Sep 21, 2023
I think so, it is the In OTP 26, it seems there is more than one "user" process, so the search found more than 1 result. The other test failed because the initial function seems to be changed in this new version too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a couple of tests for OTP26. There are more elegant ways, but it works. Finding a process that doesn't change between OTP versions would be better. If you know another process that is not ":user", I can give it a try.
I updated the deps because the phoenix pubsub version was retired, and I had a problem with ecto and OTP26, so I went ahead and I updated all the deps. It seems to work perfectly, but I can undo the changes if you prefer.