Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback to ipv4/ipv6 in the event of an unreachable host error #101

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Gazler
Copy link
Member

@Gazler Gazler commented Oct 16, 2024

If there is a request failure and the reason implies that the error is due to the usage being ipv4 or ipv6, the alternative is set and the request retries. A variable is used to determine if a retry should be attempted or not. If it is false, this means that a retry is already being attempted, and the request should raise.

This is based on:

https://github.com/elixir-lang/elixir/blob/9c42348f6407fa315bae00acffe433e9417e2c2e/lib/mix/lib/mix/utils.ex#L687

If there is a request failure and the reason implies that the error is
due to the usage being ipv4 or ipv6, the alternative is set and the
request retries. A variable is used to determine if a retry should be
attempted or not. If it is false, this means that a retry is already
being attempted, and the request should raise.

This is based on:

https://github.com/elixir-lang/elixir/blob/9c42348f6407fa315bae00acffe433e9417e2c2e/lib/mix/lib/mix/utils.ex#L687
@Gazler Gazler merged commit f13003f into phoenixframework:main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants