This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
Add ARIA roles to tabs #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also does some stylistic changes as well, like capitalizing ARIA and treating it like the other generic attributes.
According to experts (including both an invited expert advisor and a co-chair of ARIA committee), aria-controls is not needed, and actually annoying in JAWS.
Also use the tab bar orientation setter to set the default orientation.
Before, we needed to clamp down on these types for aria attributes. This is (a) backwards incompatible and (b) not needed anymore.
jasongrout
commented
Jul 27, 2019
| @@ -893,6 +914,9 @@ class TabBar<T> extends Widget { | |||
| let ci = this._currentIndex; | |||
| let bh = this.insertBehavior; | |||
|
|
|||
|
|
|||
| // TODO: do we need to do an update to update the aria-selected attribute? | |||
There was a problem hiding this comment.
@afshin points out that the two TODO items should be taken care of. Agreed. In a later version I just deleted the two notes, which may indicate that I thought about it and decided it wasn't necessary. That should be double-checked.
|
For reference, this is a comparison between this PR's branch, and that of #405: jasongrout/phosphor@aria-menus...jasongrout:aria-tabs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #405 to also add ARIA roles to tabs. Merge #405 first.