Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix for #1576 - photos sorting behaviour consistent for Gallery, Album and Tag views #1580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashwingj
Copy link
Contributor

@ashwingj ashwingj commented Jun 1, 2015

The fix was made based on the following observations

  • Inconsistency between how sorting behaviour is applied between the initial PhotoController::List_ action and subsequent javascript ApiPhotoController::List_ actions
    • PhotoController never set IsAlbum and IsTag variables and hence code to apply dateTaken,asc sorting behaviour for Tag and Album was never executed (if condition never evaluated to true). Additional evidence was the 'Variable not defined' errors for IsAlbum and IsTag in the error log.
    • Javascript applied dateTaken,asc sorting for Album only and dateUploaded,desc for all (including Tags)

Fix: Proposed a method of detecting IsAlbum and removed IsTag (to be consistent with Javascript behaviour).

  • this->permissions->canUpload call in the photos-sub-heading.php file started throwing 'definition not found errors' as soon as we fixed the IsAlbum variable problem
    • No canUpload method found in any source file. No idea what the permissions class was either.

Fix: Commenting out for the time being until able to figure out what this is ... repo owners, some guidance would be welcome here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant