First pass at using simple memcached_get when possible #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In binary mode, memcached_mget always issues two packets, which ends up making it slower than ascii mode for many users. This commit incorrectly believes that libmemcached supports UDP get, it does not, so that assumption needs to be reworked. Maybe UDP mode should automatically make both a TCP and a UDP connection? Or return a class with fewer methods so that it can be introspected or used with a magic method not defined to fall back to a TCP connection class as needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In binary mode, memcached_mget always issues two packets, which ends up
making it slower than ascii mode for many users.
This commit incorrectly believes that libmemcached supports UDP get, it
does not, so that assumption needs to be reworked. Maybe UDP mode should
automatically make both a TCP and a UDP connection? Or return a class
with fewer methods so that it can be introspected or used with a magic
method not defined to fall back to a TCP connection class as needed?