Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XForms documentation (part of php/doc-en#3579) #177

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

jimwins
Copy link
Member

@jimwins jimwins commented Jul 24, 2024

Removes the translation in advance of it being removed entirely.

@cmb69
Copy link
Member

cmb69 commented Jul 24, 2024

Thank you! Before this can be merged, php/doc-en#3601 needs to be merged, and then the EN-Revision for the modified file needs to be updated, and possibly other pending updates to that file need to be made.

@jimwins
Copy link
Member Author

jimwins commented Jul 26, 2024

Updated the revision. The reason for going ahead and deleting features/xforms.xml now, in this and other translations, is so that when reference to it removed from doc-base/manual.xml.in it won't immediately break the build for all of those translations. In the (hopefully short) time between it being removed from the translations and from doc-en, the translations should just fall back to the English version.

@jimwins jimwins closed this Aug 8, 2024
@jimwins jimwins deleted the issue-3579 branch August 8, 2024 00:21
@jimwins jimwins restored the issue-3579 branch August 8, 2024 00:26
@jimwins
Copy link
Member Author

jimwins commented Aug 8, 2024

Looked in the wrong branch and thought this had been done. Still needs doing.

@jimwins jimwins reopened this Aug 8, 2024
@cmb69
Copy link
Member

cmb69 commented Aug 8, 2024

Maybe we should not update the EN-Revision here; there may have been other changes to this file in between (or haven't there any). Not sure what's best for the active translators; maybe @msamesch can comment?

@jimwins
Copy link
Member Author

jimwins commented Aug 8, 2024

There were no other untranslated changes to that file, so chopping out that paragraph and updating the EN-Revision should bring it up to date. (I made PRs for every language, but only changed the EN-Revision if there were no other untranslated changes, was just doc-es and doc-it. The change without updating EN-Revision was merged to doc-es and doc-it is still pending for someone to deal with.)

@msamesch
Copy link
Contributor

msamesch commented Aug 8, 2024

I forgot about this PR while I was waiting for the corresponding update in EN. Otherwise it's fine with me. Also meanwhile chapters/tutorial.xml was updated in c73ea82. Thanks for the update anyway.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimwins, as far as I know, doc-it is broken for weeks (if not longer), so probably no need to worry about another break.

@cmb69 cmb69 merged commit e95edbd into php:master Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants