Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stream wrappers and context options from function method listing #3422

Conversation

haszi
Copy link
Contributor

@haszi haszi commented May 28, 2024

Add a role attribute with an appropriate value to all stream wrappers and context options. PhD is patched also to index these as non-functions/methods and with that these entries are removed from the function method listing.

Edit:
The PhD side of this fix is this one.

@Girgias
Copy link
Member

Girgias commented May 29, 2024

Can you move the whitespace commit into a separate PR so that I can [skip-revcheck] the second commit and apply it on translations?

@Girgias
Copy link
Member

Girgias commented Jun 3, 2024

Merged the other PR, can you rebase this one? :)

Add a role attribute with an appropriate value to all stream wrappers and context options. PhD is patched also to index these as non-functions/methods and with that these entries are removed from the function method listing.
@haszi haszi force-pushed the Remove-stream-wrappers-and-context-options-from-function-method-listing branch from a35a334 to f3b9c06 Compare June 3, 2024 19:55
@haszi
Copy link
Contributor Author

haszi commented Jun 9, 2024

@Girgias Rebase done.

@Girgias Girgias merged commit 8bc832a into php:master Jun 14, 2024
2 checks passed
Girgias added a commit to php/doc-de that referenced this pull request Jun 14, 2024
Girgias added a commit to php/doc-es that referenced this pull request Jun 14, 2024
Girgias added a commit to php/doc-fr that referenced this pull request Jun 14, 2024
Girgias added a commit to php/doc-it that referenced this pull request Jun 14, 2024
Girgias added a commit to php/doc-ja that referenced this pull request Jun 14, 2024
Girgias added a commit to php/doc-pt_br that referenced this pull request Jun 14, 2024
Girgias added a commit to php/doc-ru that referenced this pull request Jun 14, 2024
Girgias added a commit to php/doc-tr that referenced this pull request Jun 14, 2024
Girgias added a commit to php/doc-uk that referenced this pull request Jun 14, 2024
Girgias added a commit to php/doc-zh that referenced this pull request Jun 14, 2024
@haszi haszi deleted the Remove-stream-wrappers-and-context-options-from-function-method-listing branch June 14, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants