-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stream wrappers and context options from function method listing #3422
Merged
Girgias
merged 1 commit into
php:master
from
haszi:Remove-stream-wrappers-and-context-options-from-function-method-listing
Jun 14, 2024
Merged
Remove stream wrappers and context options from function method listing #3422
Girgias
merged 1 commit into
php:master
from
haszi:Remove-stream-wrappers-and-context-options-from-function-method-listing
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you move the whitespace commit into a separate PR so that I can |
Merged the other PR, can you rebase this one? :) |
Add a role attribute with an appropriate value to all stream wrappers and context options. PhD is patched also to index these as non-functions/methods and with that these entries are removed from the function method listing.
haszi
force-pushed
the
Remove-stream-wrappers-and-context-options-from-function-method-listing
branch
from
June 3, 2024 19:55
a35a334
to
f3b9c06
Compare
@Girgias Rebase done. |
Girgias
added a commit
to php/doc-de
that referenced
this pull request
Jun 14, 2024
Girgias
added a commit
to php/doc-es
that referenced
this pull request
Jun 14, 2024
Girgias
added a commit
to php/doc-fr
that referenced
this pull request
Jun 14, 2024
Girgias
added a commit
to php/doc-it
that referenced
this pull request
Jun 14, 2024
Girgias
added a commit
to php/doc-ja
that referenced
this pull request
Jun 14, 2024
Girgias
added a commit
to php/doc-pt_br
that referenced
this pull request
Jun 14, 2024
Girgias
added a commit
to php/doc-ru
that referenced
this pull request
Jun 14, 2024
Girgias
added a commit
to php/doc-tr
that referenced
this pull request
Jun 14, 2024
Girgias
added a commit
to php/doc-uk
that referenced
this pull request
Jun 14, 2024
Girgias
added a commit
to php/doc-zh
that referenced
this pull request
Jun 14, 2024
haszi
deleted the
Remove-stream-wrappers-and-context-options-from-function-method-listing
branch
June 14, 2024 18:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a role attribute with an appropriate value to all stream wrappers and context options. PhD is patched also to index these as non-functions/methods and with that these entries are removed from the function method listing.
Edit:
The PhD side of this fix is this one.