Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more description for hash extension #3630

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Conversation

jimwins
Copy link
Member

@jimwins jimwins commented Jul 30, 2024

Based on this comment by @cmb69:
#3616 (comment)

Related to issue #3616.

Based on this comment by @cmb69:
php#3616 (comment)

Related to issue php#3616.
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits regarding markup. Otherwise this looks already very good to me. Thank you!

reference/hash/book.xml Outdated Show resolved Hide resolved
reference/hash/book.xml Outdated Show resolved Hide resolved
reference/hash/book.xml Outdated Show resolved Hide resolved
reference/hash/book.xml Outdated Show resolved Hide resolved
reference/hash/book.xml Outdated Show resolved Hide resolved
reference/hash/book.xml Outdated Show resolved Hide resolved
reference/hash/book.xml Outdated Show resolved Hide resolved
reference/hash/book.xml Outdated Show resolved Hide resolved
reference/hash/book.xml Outdated Show resolved Hide resolved
reference/hash/book.xml Outdated Show resolved Hide resolved
jimwins added a commit to php/doc-base that referenced this pull request Jul 31, 2024
@jimwins jimwins marked this pull request as ready for review July 31, 2024 15:38
@jimwins jimwins merged commit a9c0102 into php:master Jul 31, 2024
2 checks passed
@jimwins jimwins deleted the hash-explanation branch July 31, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants