Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to constants #102

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Add links to constants #102

merged 1 commit into from
Feb 23, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Feb 22, 2024

Add links to constants with IDs in the following two standard formats (xml:id doesn't have to be on the <constant> element):

<constant xml:id="extension-namespace-or-classname.constants.name-of-constant">
 Extension\Namespace\Or\ClassName::NAME_OF_CONSTANT
</constant>

<constant xml:id="constant.name-of-constant">
 NAME_OF_CONSTANT
</constant>

Please note that there is a large number of constants not using one of these standard formats.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good initial improvement

@Girgias Girgias merged commit 2c7a8f8 into php:master Feb 23, 2024
4 checks passed
@haszi haszi deleted the Constant-links branch February 23, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants