Enable nested roles #103
Merged
Enable nested roles #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2024 22:45
Refactor role to be and array instead of a string to allow nesting of roles. Use the indent method to format constant list tables. Add tests for regular, table formatted and nested role containing variablelists.
Girgias
reviewed
Feb 23, 2024
Add methods to push, pop and get role, and use these for all role accesses. Make underlying $role array private. Add comment on $role array being a LIFO stack.
Girgias
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
roleto be and array instead of a string to allow nesting of roles. Use theindentmethod to format constant list tables. Add tests for regular, table formatted and nested role containing<variablelist>s.This PR fixes the shortcoming of the previous
role="constant_list"PR and enables nested roles in<variablelist>s which allows to format constant lists in the documentation as tables without these being thrown off by elements that are rendered by adding roles to them (e.g.<literal>).