Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-98 #105

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Fix GH-98 #105

merged 2 commits into from
Feb 27, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Feb 26, 2024

Store IDs of non-chunked elements.
Closes #98.

Store IDs of non-chunked elements.
Closes php#98.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you!

@Girgias
Copy link
Member

Girgias commented Feb 26, 2024

Well the tests seem to fail 🤔

@haszi
Copy link
Contributor Author

haszi commented Feb 26, 2024

Well the tests seem to fail 🤔

Yeah, for some reason it doesn't index anything on GH but works perfectly fine locally. I'm trying to figure out what's going on but don't really have a clue what it could be yet.

@haszi haszi requested a review from Girgias February 26, 2024 19:31
@haszi
Copy link
Contributor Author

haszi commented Feb 26, 2024

It turns out that 'index' => true in Config doesn't do anything (changed it to 'force_index' => true) and the $indexes property of Format is actually the list of indexes read from cache/sqlite and Index's $nfo property holds the parsed indexes.

Anyway, the test passes now and this is ready for review.

@haszi
Copy link
Contributor Author

haszi commented Feb 26, 2024

I've changed the private $nfo property to protected so I can access it from TestIndex but now I'm thinking that adding a getNfo() method to Index may be a better solution.

@Girgias Girgias merged commit 262926d into php:master Feb 27, 2024
8 checks passed
@haszi haszi deleted the Fix-GH-98 branch February 27, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linking to ID on section which is not chunked does not generate a proper link
2 participants