Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the same indexing database throughout #118

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Use the same indexing database throughout #118

merged 1 commit into from
Apr 25, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Apr 25, 2024

Use the same indexing database in every part of PhD by always retrieving it from indexcache and always set indexcache before any indexing or rendering is done in render.php.

Girgias
Girgias approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory look, but LCTM

@Girgias Girgias merged commit ef13e91 into php:master Apr 25, 2024
8 checks passed
@haszi haszi deleted the Use-the-same-indexing-database branch April 25, 2024 16:03
Girgias added a commit that referenced this pull request Apr 25, 2024
@Girgias
Revert "Use the same indexing database throughout (#118)"
f93552a 
This doesn't seem to create the DB properly and is failing the builds.

This reverts commit ef13e91.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haszi @Girgias