Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fallback to master when detected branch name is unknown #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added fallback to master when detected branch name is unknown #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/php/libsdk/SDK/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@ public static function getKnownBranches() : array
public static function setCurrentBranchName(string $name) : void
{/*{{{*/
if (!array_key_exists($name, self::getKnownBranches())) {
throw new Exception("Unsupported branch '$name'");
fwrite(STDERR, "Unsupported branch '$name'. Falling back to 'master'.");

$name = 'master';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the hard failure, instead of a soft fallback that could indicate user error.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the user error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for unsupported branches (and no Git available; thanks, I was missing this in my reply to #11), the user should explicitly specify the branch. If I'm not mistaken, passing -b master should work in this case already.

}

self::$currentBranchName = $name;
Expand Down