Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare called methods in interfaces #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Declare called methods in interfaces #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/php/libsdk/SDK/Build/PGO/Interfaces/PHP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ public function up() : void;
public function down(bool $force = false) : void;
public function getVersion(bool $short = false) : string;
public function getExeFilename() : string;
public function getRootDir() : string;
public function getExtRootDir() : string;
}
6 changes: 5 additions & 1 deletion lib/php/libsdk/SDK/Build/PGO/Interfaces/TrainingCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

interface TrainingCase
{
public function __construct(PGOConfig $conf, ?Server $srv_http, ?Server\DB $srv_db);
public function __construct(PGOConfig $conf, ?Server\HTTP $srv_http, ?Server\DB $srv_db);

/* Name of the training case, usually should be same as dirname and namespace. */
public function getName() : string;
Expand All @@ -24,4 +24,8 @@ public function run() : void;

/* Get training type, it's like "web", "cli", etc.*/
public function getType() : string;

public function getJobFilename() : string;

public function httpStatusOk(int $status) : bool;
}
4 changes: 2 additions & 2 deletions pgo/cases/drupal/TrainingCaseHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var mixed */
Expand All @@ -23,7 +23,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 8;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $maria)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $maria)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/joomla/TrainingCaseHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var mixed */
Expand All @@ -26,7 +26,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 4;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $maria)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $maria)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/mediawiki/TrainingCaseHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var mixed */
Expand All @@ -23,7 +23,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 4;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $srv_db)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $srv_db)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/pgo01org/TrainingCaseHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var ?Interfaces\Server\DB */
Expand All @@ -26,7 +26,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 12;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $maria)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $maria)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/symfony_demo/TrainingCaseHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var mixed */
Expand All @@ -23,7 +23,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 4;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $srv_db)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $srv_db)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/symfony_demo_pdo_mysql/TrainingCaseHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var ?Interfaces\Server\DB */
Expand All @@ -26,7 +26,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 4;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $srv_db)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $srv_db)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down
4 changes: 2 additions & 2 deletions pgo/cases/wordpress/TrainingCaseHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var string */
protected $base;

/** @var ?Interfaces\Server $nginx */
/** @var ?Interfaces\Server\HTTP $nginx */
protected $nginx;

/** @var ?Interfaces\Server\DB */
Expand All @@ -26,7 +26,7 @@ class TrainingCaseHandler extends Abstracts\TrainingCase implements Interfaces\T
/** @var int */
protected $max_runs = 4;

public function __construct(Config $conf, ?Interfaces\Server $nginx, ?Interfaces\Server\DB $maria)
public function __construct(Config $conf, ?Interfaces\Server\HTTP $nginx, ?Interfaces\Server\DB $maria)
{
if (!$nginx) {
throw new Exception("Invalid NGINX object");
Expand Down