ZPP: add F type check for callables that do not free trampolines #12375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
reviewed
Oct 6, 2023
Girgias
force-pushed
the
zpp-F-no-free-trampolines
branch
from
47eadcf to
bee31be
Compare
|
I didn't check this carefully and I see some tests failures, but I like the idea. |
Girgias
force-pushed
the
zpp-F-no-free-trampolines
branch
from
bee31be to
c59d1c4
Compare
nielsdos
approved these changes
Oct 9, 2023
As refetching it with the new FCC API does get tedious
Girgias
force-pushed
the
zpp-F-no-free-trampolines
branch
from
77007f1 to
928faec
Compare
Girgias
force-pushed
the
zpp-F-no-free-trampolines
branch
from
14056cb to
c8a2bb2
Compare
dstogov
reviewed
Oct 11, 2023
| @@ -1794,9 +1794,9 @@ ZEND_API ZEND_COLD void zend_argument_value_error(uint32_t arg_num, const char * | |||
| Z_PARAM_DOUBLE_EX(dest, is_null, 1, 0) | |||
|
|
|||
| /* old "f" */ | |||
| #define Z_PARAM_FUNC_EX(dest_fci, dest_fcc, check_null, deref) \ | |||
| #define Z_PARAM_FUNC_EX(dest_fci, dest_fcc, check_null, deref, free_trampoline) \ | |||
There was a problem hiding this comment.
This may break third-party extensions.
e.g. pecl/memcached https://github.com/dstogov/php-src/actions/runs/6483064666/job/17603831990
I think it's better to keep Z_PARAM_FUNC_EX unchanged and add Z_PARAM_FUNC_EX2.
cc: @iluuu1994 @nielsdos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would simplify the implementation of #12340 by quite a bit.