Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Deprecate implicit nullable parameter types #12959

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[RFC] Deprecate implicit nullable parameter types #12959

merged 1 commit into from
Mar 13, 2024

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Dec 15, 2023 •
edited
Loading

@kocsismate kocsismate added the RFC label Dec 15, 2023
@kocsismate kocsismate requested a review from Girgias December 15, 2023 14:50
@kocsismate kocsismate force-pushed the deprecate-implicit-nullability branch from 808ffa6 to abdf8b2 Compare December 16, 2023 06:45
@kocsismate kocsismate force-pushed the deprecate-implicit-nullability branch 4 times, most recently from 00e1b5f to 239a2b4 Compare December 17, 2023 18:14
Girgias
Girgias approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, still drafting the RFC

Zend/tests/type_declarations/scalar_none.phpt Show resolved Hide resolved
Zend/tests/type_declarations/scalar_null.phpt Outdated Show resolved Hide resolved
Zend/tests/variadic/adding_additional_optional_parameter.phpt Outdated Show resolved Hide resolved
Zend/tests/variadic/adding_additional_optional_parameter_error.phpt Outdated Show resolved Hide resolved
ext/reflection/tests/ReflectionClass_export_basic1.phpt Outdated Show resolved Hide resolved
ext/reflection/tests/parameters_002.phpt Outdated Show resolved Hide resolved
@kocsismate kocsismate mentioned this pull request Dec 21, 2023
Closed
Girgias
Girgias reviewed Dec 23, 2023
View reviewed changes
Zend/zend_compile.c Outdated Show resolved Hide resolved
@kocsismate kocsismate force-pushed the deprecate-implicit-nullability branch from 8bc9363 to 7ed7137 Compare December 24, 2023 13:16
@kocsismate kocsismate force-pushed the deprecate-implicit-nullability branch from 7ed7137 to f644467 Compare February 11, 2024 20:53
@kocsismate kocsismate force-pushed the deprecate-implicit-nullability branch from f644467 to 0c855aa Compare March 13, 2024 19:30
@kocsismate kocsismate force-pushed the deprecate-implicit-nullability branch from 0c855aa to 0248ab9 Compare March 13, 2024 20:39
@kocsismate kocsismate merged commit 330cc5c into php:master Mar 13, 2024
7 of 10 checks passed
@kocsismate kocsismate deleted the deprecate-implicit-nullability branch March 13, 2024 20:40
This was referenced Mar 18, 2024
Closed
Merged
@jrfnl jrfnl mentioned this pull request Apr 1, 2024
Merged
@masakielastic masakielastic mentioned this pull request May 26, 2024
Open
shaismithu

This comment was marked as off-topic.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaismithu shaismithu shaismithu left review comments

@Girgias Girgias Girgias approved these changes

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@derickr derickr Awaiting requested review from derickr derickr is a code owner

Assignees
No one assigned
Labels
Category: Engine Extension: date Extension: opcache Extension: pdo_pgsql Extension: reflection Extension: spl RFC SAPI: fpm SAPI: phpdbg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocsismate @Girgias @shaismithu