Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GHSA-9pqp-7h25-4f32.phpt on Windows #16933

Draft
wants to merge 3 commits into
base: PHP-8.2
Choose a base branch
from
Draft

Enable GHSA-9pqp-7h25-4f32.phpt on Windows #16933

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91979c7
Enable GHSA-9pqp-7h25-4f32.phpt on Windows
cmb69 Nov 25, 2024
11bed35
Use a socket on Windows
cmb69 Dec 4, 2024
61caee5
Don't pass file on command line
cmb69 Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tests/basic/GHSA-9pqp-7h25-4f32.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ GHSA-9pqp-7h25-4f32
if (!getenv('TEST_PHP_CGI_EXECUTABLE')) {
die("skip php-cgi not available");
}
if (substr(PHP_OS, 0, 3) == 'WIN') {
die("skip not for Windows in CI - probably resource issue");
}
?>
--FILE--
<?php
Expand All @@ -21,7 +18,6 @@ function test($boundaryLen) {
getenv('TEST_PHP_CGI_EXECUTABLE'),
'-C',
'-n',
__DIR__ . '/GHSA-9pqp-7h25-4f32.inc',
];

$boundary = str_repeat('A', $boundaryLen);
Expand All @@ -42,7 +38,7 @@ function test($boundaryLen) {
]);

$spec = [
0 => ['pipe', 'r'],
0 => [PHP_OS_FAMILY === "Windows" ? 'socket' : 'pipe', 'r'],
1 => STDOUT,
2 => STDOUT,
];
Expand Down
Loading