allow urlencode(int)

[divinity76]

in strict mode it's kindof annoying to have to cast-to-string when you have a string|int variable you need to urlencode. There is no ambiguity as to how to urlencode integers, so it shouldn't be a problem.

TypeError: urlencode(): Argument #1 ($string) must be of type string, int given

has happened to me enough times now that I bothered to make PR to allow it.

Fwiw the integer path could be micro-optimized to bypass php_raw_url_encode() entirely, at least when the integer is not negative, but for brevity, I didn't bother micro-optimizing it.

[nielsdos]

This is very ad hoc... If we start doing this, what other function do we have to relax?
url-encoding a number doesn't really make a lot of sense to me. This defeats the point of strict types.
In short: I'm against this change

[divinity76]

If we start doing this, what other function do we have to relax?

perhaps escapeshellarg. (i don't recommend escapeshellarg tho)

This defeats the point of strict types.

fwiw comparing PHP to Perl and Javascript:

$ cat test.pl   
use strict;
use warnings;
use URI::Escape;

my $encoded = uri_escape(1);
print "$encoded\n";
$ perl test.pl
1
$ cat test.js
"use strict";
console.log(encodeURIComponent(1));
$ nodejs test.js
1
$ cat test.php
<?php
declare(strict_types=1);
var_dump(urlencode(1));
$ php test.php
PHP Fatal error:  Uncaught TypeError: urlencode(): Argument #1 ($string) must be of type string, int given in /home/hans/test.php:3
Stack trace:
#0 /home/hans/test.php(3): urlencode()
#1 {main}
  thrown in /home/hans/test.php on line 3

both Perl and JS allows it in strict mode 🤔

url-encoding a number doesn't really make a lot of sense to me.

it's when you have a int|string variable and you need to make sure it's safe to include in a url.
my latest encounter was

'url' => '(...)?campaignid=' . urldecode($campaign['campaignid']),

where campaignid could be int|string, so my options were

'url' => '(...)?' . http_build_query(array('campaignid' => $campaign['campaignid']))

'url' => '(...)?campaignid=' . urldecode((string)$campaign['campaignid']),

In short: I'm against this change

that's fair

[nielsdos]

The strict modes of javascript and perl are unrelated to types, so they're not a fair comparison.

[divinity76]

well http_build_query accepts array(1=>1) (and for good reason imo)

[Girgias]

I'm not convinced either, so this needs a discussion on internals at the minimum, if not an RFC.