Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH-17234: Numeric parent hook call fails with assertion #17236

Open
wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
Open

Fix GH-17234: Numeric parent hook call fails with assertion #17236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Zend/tests/property_hooks/gh17234.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
GH-17234 (Numeric parent hook call fails with assertion)
--FILE--
<?php
class ParentC {}
class Child extends ParentC {
public $a {
get {
return parent::${0}::get ();
}
}
}
?>
--EXPECTF--
Fatal error: Must not use parent::$0::get() in a different property ($a) in %s on line %d
4 changes: 2 additions & 2 deletions Zend/zend_compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5098,7 +5098,8 @@ static bool zend_compile_parent_property_hook_call(znode *result, zend_ast *ast,
zend_error_noreturn(E_COMPILE_ERROR, "Cannot create Closure for parent property hook call");
}

zend_string *property_name = zend_ast_get_str(class_ast->child[1]);
zval *property_hook_name_zv = zend_ast_get_zval(class_ast->child[1]);
zend_string *property_name = zval_get_string(property_hook_name_zv);
iluuu1994 marked this conversation as resolved.
Show resolved Hide resolved
zend_string *hook_name = zend_ast_get_str(method_ast);
zend_property_hook_kind hook_kind = zend_get_property_hook_kind_from_name(hook_name);
ZEND_ASSERT(hook_kind != (uint32_t)-1);
Expand All @@ -5122,7 +5123,6 @@ static bool zend_compile_parent_property_hook_call(znode *result, zend_ast *ast,
zend_op *opline = get_next_op();
opline->opcode = ZEND_INIT_PARENT_PROPERTY_HOOK_CALL;
opline->op1_type = IS_CONST;
zend_string_copy(property_name);
opline->op1.constant = zend_add_literal_string(&property_name);
opline->op2.num = hook_kind;

Expand Down
Loading