Skip to content

Commit

Permalink
Fixed getReleaseAssetsForPackage() for repositories with names that d…
Browse files Browse the repository at this point in the history
…o not match the package name.
  • Loading branch information
mickverm committed Oct 14, 2024
1 parent 6d83fec commit 832d658
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions src/Downloading/GithubPackageReleaseAssets.php
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,16 @@ private function selectMatchingReleaseAsset(TargetPlatform $targetPlatform, Pack
/** @return list<array{name: non-empty-string, browser_download_url: non-empty-string, ...}> */
private function getReleaseAssetsForPackage(Package $package): array
{
// @todo confirm prettyName will always match the repo name - it might not
if (($download = $package->downloadUrl) !== null && !str_contains($download, $package->name)) {
// Converts https://api.github.com/repos/<user>/<repository>/zipball/<sha>" to "<user>/<repository>"
$path = parse_url($download)['path'];
$name = implode('/', array_slice(explode('/', $path), 2, 2));
} else {
$name = $package->name;
}

$request = AddAuthenticationHeader::withAuthHeaderFromComposer(
new Request('GET', $this->githubApiBaseUrl . '/repos/' . $package->name . '/releases/tags/' . $package->version),
new Request('GET', $this->githubApiBaseUrl . '/repos/' . $name . '/releases/tags/' . $package->version),
$package,
$this->authHelper,
);
Expand Down

0 comments on commit 832d658

Please sign in to comment.