usability: avoid gap between a wrapped link in aside bar #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming conference links are wrapped and clicking between should activate the link, not require the user to decide to click the upper or bottom line of the link.
|
I think in this case, usability loses out... I would prefer the link to be the text directly rather than the block. example
|
saundefined
added
Waiting on Author
Status: Needs Feedback
and removed
Waiting on Review
labels
|
Ah, another idea which keeps the hover underlining 'normal' and still no click-gap on wrapped link: aside.tips li {margin-bottom:0.5rem;}
aside.tips a {padding-top:0.5rem;}It also keeps the li items a bit separated (for better or 'worse'?) |
Looks good, |
instead of making a-tags display:inline-block, this CSS change adjusts the line-height of the li-tag, so the wrapped conference links are kept normal and has no link-gaps.
|
🚀 Commit 40abc7c Deployed on https://web-php-pr-439.preview.thephp.foundation |
|
Instead of the padding-top 'hack' I now adjusted the line-height of the li-tag... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming conference links are wrapped and clicking between should activate the link, not require the user to decide to click the upper or bottom line of the link.