Fix German translation of the PHP 8.3 release page #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Commit c021a92 Deployed on https://web-php-pr-925.preview.thephp.foundation |
|
Note: https://www.php.net/releases/8.2/de.php / #903 is similarly terrible, but as it is not as prominent, given it's not the newest release, I did not yet bother fixing the translation. A short term fix might be simply deletion the German version for 8.2 / reverting #903. |
|
I'm going to merge it, if there'll any improvement, let's do it in the new PR :) Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current translation is frankly terrible. It contains several spelling and grammar mistakes and it is very liberal in the translation, completely rephrasing (and dropping) important aspects of the English original.
The updated translation matches the English original pretty closely. For the ext/random and Override stuff I was the original author of the English original.
/cc @msamesch @joshuaruesweg as the maintainers of doc-de. I've attempted to use the terminology that is used within the German documentation (e.g. Elternklasse instead of Basisklasse), I'd appreciate another pair of eyes :-)
see #902