Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Split test suite #940

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Enhancement: Split test suite #940

merged 1 commit into from
Feb 13, 2024

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Feb 12, 2024 •
edited
Loading

This pull request

  • splits the test suite

Follows #605.

💁‍♂️ Splitting the test suite could have the following advantages:

  • we could cater to different bootstrapping requirements
    • end-to-end tests require a server to be running
    • unit tests require autoloading to be set uo
  • we could now start using PHPUnit\Framework\TestCase for tests where appropriate (and document corresponding namespaces in composer.json via autoload-dev

@github-actions GitHub Actions
Copy link

🚀 Commit f24c916 Deployed on https://web-php-pr-940.preview.thephp.foundation

saundefined
saundefined approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saundefined saundefined merged commit bb83a9c into php:master Feb 13, 2024
3 checks passed
@localheinz localheinz deleted the feature/split branch February 13, 2024 07:08
@localheinz
Copy link
Contributor Author

Thank you, @saundefined!

@localheinz localheinz mentioned this pull request Feb 13, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saundefined saundefined saundefined approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @saundefined