Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable Polish translation again", for now #989

Merged
merged 1 commit into from
May 10, 2024

Conversation

Sobak
Copy link
Contributor

@Sobak Sobak commented May 9, 2024

This reverts commit 70bd5e0.

While the docs do build, I belive there's at least a few specific action points we should tackle before we open them up to the world.

I really wanna avoid going into the infinite beta mode, i.e. "lemme just do this >>one more thing<< and then we'll surely release" but at the same time I want to stay responsible and as such, I wanna make sure few things are done before we start showing this up for people in Poland.

  • some infra problem, the Polish option does appear in the select but it leads to 404
  • getting rid of some terribly outdated pages: to stay specific I would say lets at least deal with files without En-Revision in most used reference/* directories
  • update parameter names to match the PHP's source code: while many files are technically up-to-date (from revcheck's standpoint) they are using translated parameter names. I believe this is what all documentations used to do in the old days. Now that we have named parameters it means that people will get invalid information from the manual. I hope that there's some script in doc-base that I can utilize to find such cases, otherwise I might end up writing something myself
  • generally speaking I believe we should run all kinds of QA scripts that are available. Better to do it now that the documentation is small rather than much later
  • minor point: I remembered now that there are some translations embedded in the phd itself. I think I even wrote a script eons ago that can show if the files went out of sync with the English version. I have no clue if phd received much love in recent years but the Polish translations file in its repo should be checked as well

This reverts commit 70bd5e0.

While the docs do build, I belive there's at least a few specific action
points we should tackle before we open them up to the world.
@Sobak
Copy link
Contributor Author

Sobak commented May 9, 2024

Hi @Girgias

for some reason I'm unable to assign reviewers to my PRs. I thought that perhaps it's a paid feature on GitHub but I've seen you do it before so now I'm unsure. Anyhow, can you please have a look?

Copy link

github-actions bot commented May 9, 2024

🚀 Commit 6abd27b Deployed on https://web-php-pr-989.preview.thephp.foundation

@saundefined saundefined requested a review from Girgias May 9, 2024 16:53
@Girgias Girgias merged commit f6e47b7 into php:master May 10, 2024
4 checks passed
@Girgias
Copy link
Member

Girgias commented May 10, 2024

One needs to be a maintainer of a repo to be able to have a PR assigned to one-self.

@Sobak Sobak deleted the disable-polish-docs branch May 10, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants