-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visual regression tests #994
Conversation
Co-authored-by: Roman Pronskiy <[email protected]>
🚀 Commit 7b11b96 Deployed on https://web-php-pr-994.preview.thephp.foundation |
Going through the list of PRs and issues, we can see that there are a bunch of UI/CSS things. The problem is that we currently do not have any experts in this area, and moreover, no QA experts to verify if the changes do not break something. With this PR Sergey and I propose to introduce screenshot regression testing. It works like this:
We'd like your feedback on this idea. And if it makes sense, we'll implement the missing parts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, as at least it is possible to see the difference between the current website render and the proposed change.
Example: saundefined#21 |
Co-authored-by: Derick Rethans <[email protected]>
I'm going to merge this PR later this week if there are no objections. |
/cc @pronskiy