fix: interfaces, traits, enums can not be readonly

phparkitect · Mar 30, 2024 · a4b5f8c · a4b5f8c
1 parent fbbcbe5
commit a4b5f8c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Expression/ForClasses/IsReadonly.php b/src/Expression/ForClasses/IsReadonly.php
@@ -20,7 +20,7 @@ public function describe(ClassDescription $theClass, string $because): Descripti
 
     public function evaluate(ClassDescription $theClass, Violations $violations, string $because): void
     {
-        if ($theClass->isReadonly()) {
+        if ($theClass->isReadonly() || $theClass->isInterface() || $theClass->isTrait() || $theClass->isEnum()) {
             return;
         }
 

diff --git a/tests/Unit/Expressions/ForClasses/IsReadonlyTest.php b/tests/Unit/Expressions/ForClasses/IsReadonlyTest.php
@@ -69,7 +69,7 @@ public function test_interfaces_can_not_be_readonly_and_should_be_ignored(): voi
             [],
             null,
             false,
-            true,
+            false,
             false,
             true,
             false,
@@ -90,7 +90,7 @@ public function test_traits_can_not_be_readonly_and_should_be_ignored(): void
             [],
             null,
             false,
-            true,
+            false,
             false,
             false,
             true,
@@ -111,7 +111,7 @@ public function test_enums_can_not_be_readonly_and_should_be_ignored(): void
             [],
             null,
             false,
-            true,
+            false,
             false,
             false,
             false,