Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a And expression #395

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hgraca
Copy link
Contributor

@hgraca hgraca commented Jul 26, 2023

This will allow for complex nested expressions, like ANDs inside ORs.

@fain182
Copy link
Collaborator

fain182 commented Aug 5, 2023

Arkitekt already supports AndThat() (but we forgot to document it, sorry), do you have use cases where this should not be enough?

@hgraca
Copy link
Contributor Author

hgraca commented Aug 5, 2023

Yes, andThat only works at the root of the expression, If we have a Not or an Or and inside we want to have an And, atm we can't do it.

This will allow for complex nested expressions, like ANDs inside ORs.
@codecov-commenter
Copy link

Codecov Report

Merging #395 (580a02b) into main (976c200) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##               main     #395      +/-   ##
============================================
+ Coverage     94.33%   94.41%   +0.07%     
- Complexity      571      577       +6     
============================================
  Files            67       68       +1     
  Lines          1500     1521      +21     
============================================
+ Hits           1415     1436      +21     
  Misses           85       85              
Files Changed Coverage Δ
src/Expression/Boolean/Andx.php 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants