Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a IsMapped expression #398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hgraca
Copy link
Contributor

@hgraca hgraca commented Jul 27, 2023

This will allow us to ensure that certain classes are always in a map. This is useful, for example, to ensure that DTOs like commands and events are always set in a map, so that a serializer knows how to serialize/deserialize them.

@codecov-commenter
Copy link

Codecov Report

Merging #398 (3aee92f) into main (976c200) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##               main     #398      +/-   ##
============================================
+ Coverage     94.33%   94.37%   +0.04%     
- Complexity      571      575       +4     
============================================
  Files            67       68       +1     
  Lines          1500     1511      +11     
============================================
+ Hits           1415     1426      +11     
  Misses           85       85              
Files Changed Coverage Δ
src/Expression/ForClasses/IsMapped.php 100.00% <100.00%> (ø)

@AlessandroMinoccheri
Copy link
Member

@hgraca Before approving, can you please add something to the readme file :) ?

This will allow us to ensure that certain classes are always in a map.
This is useful, for example, to ensure that DTOs like commands and
events are always set in a map, so that a serializer knows how
to serialize/deserialize them.
@hgraca
Copy link
Contributor Author

hgraca commented Sep 5, 2023

@AlessandroMinoccheri done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants