Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "andShould" (#326) #427

Merged
merged 4 commits into from
May 8, 2024
Merged

Add "andShould" (#326) #427

merged 4 commits into from
May 8, 2024

Conversation

sebastianstucke87
Copy link
Contributor

Added andShould as requested in #326

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (b78ecce) to head (370ed8a).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #427      +/-   ##
============================================
+ Coverage     94.19%   94.20%   +0.01%     
- Complexity      582      583       +1     
============================================
  Files            69       69              
  Lines          1533     1536       +3     
============================================
+ Hits           1444     1447       +3     
  Misses           89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlessandroMinoccheri
Copy link
Member

Hi @sebastianstucke87 can you please fix red checks?

Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AlessandroMinoccheri AlessandroMinoccheri merged commit 4530d3d into phparkitect:main May 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants