Merge pull request #191 from phpcr/fix-stream-handling

fix stream assertions and avoid phpunit warnings
phpcr · Dec 17, 2019 · 5599d57 · 5599d57
2 parents 541e0d8 + 59ee39f
commit 5599d57
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/tests/NodeTypeManagement/NodeTypeBaseCase.php b/tests/NodeTypeManagement/NodeTypeBaseCase.php
@@ -148,6 +148,8 @@ public function testValidateCustomNodeType()
 
         $node->setProperty('phpcr:class', ['x', 'y']);
         $this->session->save();
+
+        $this->addToAssertionCount(1);
     }
 
     public function testRegisterNodeTypesNoUpdate()

diff --git a/tests/Query/CharacterTest.php b/tests/Query/CharacterTest.php
@@ -120,6 +120,8 @@ public function testQueryWithColon()
             ',
             QueryInterface::JCR_SQL2
         )->execute();
+
+        $this->addToAssertionCount(1);
     }
 
     public function testQueryWithAmpersand()

diff --git a/tests/Writing/MixinReferenceableTest.php b/tests/Writing/MixinReferenceableTest.php
@@ -219,5 +219,7 @@ public function testCreateReferenceInSingleTransaction()
         $child1->setProperty('someref', $child2, PropertyType::REFERENCE);
 
         $this->session->save();
+
+        $this->addToAssertionCount(1);
     }
 }
diff --git a/tests/Writing/SetPropertyTypesTest.php b/tests/Writing/SetPropertyTypesTest.php
@@ -82,7 +82,8 @@ public function testCreateValueBinaryFromStream()
         $oldSession = $this->session;
         $this->saveAndRenewSession(); // either this
         $oldSession->logout(); // or this should close the stream
-        $this->assertNotInternalType('resource', $stream, 'The responsibility for the stream goes into phpcr who must close it');
+        // phpunit assertNotInternalType type still considers the closed stream a resource
+        $this->assertFalse(\is_resource($stream), 'The responsibility for the stream goes into phpcr who must close it');
 
         $bin = $this->session->getProperty('/tests_general_base/numberPropertyNode/jcr:content/newBinaryStream');
         $this->assertEquals(PropertyType::BINARY, $bin->getType());
@@ -102,7 +103,8 @@ public function testCreateValueBinaryFromStreamAndRead()
         $oldSession = $this->session;
         $this->saveAndRenewSession(); // either this
         $oldSession->logout(); // or this should close the stream
-        $this->assertNotInternalType('resource', $stream, 'The responsibility for the stream goes into phpcr who must close it');
+        // phpunit assertNotInternalType type still considers the closed stream a resource
+        $this->assertFalse(\is_resource($stream), 'The responsibility for the stream goes into phpcr who must close it');
 
         $bin = $this->session->getProperty('/tests_general_base/numberPropertyNode/jcr:content/newBinaryStream');
         $this->assertEquals(PropertyType::BINARY, $bin->getType());