Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 8.4 #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow PHP 8.4 #20

wants to merge 1 commit into from

Conversation

neeckeloo
Copy link

Q A
Type improvement
BC Break no
Fixed issues

Summary

Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR(s).

It seems like you need to bump the dev dependencies to get CI in a passing states.

@@ -17,7 +17,7 @@
}
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0"
"php": "^8.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would imply that it is already compatible with PHP 8.5 - which it's not.

-        "php": "^8.1",
+        "php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0" 

@neeckeloo
Copy link
Author

Thanks for the PR(s).

It seems like you need to bump the dev dependencies to get CI in a passing states.

It seems that phpspec/phpspec does not support PHP 8.4 yet.

@veewee
Copy link
Contributor

veewee commented Dec 10, 2024

It seems that phpspec/phpspec does not support PHP 8.4 yet.

It tends to adopt slowly indeed.
You could add something like this to the github action:

            - name: Set env vars for latest PHP version
              if: matrix.php-versions == '8.4'
              run: |
                export COMPOSER_IGNORE_PLATFORM_REQ=php+
                export BOX_REQUIREMENT_CHECKER=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants