Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: XML and HTML reports as string paths instead of boolean options #1129

Open
wants to merge 1 commit into
base: v2.x
Choose a base branch
from

Conversation

petrisorciprian-vitals
Copy link
Contributor

Q A
Branch v2.x
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets -

Converts the existing 'xml' and 'html' options for Codeception from booleans to strings.
Codeception supports specifying paths for these options.
If a plain option is passed (without the value, i.e. '--xml' or '--html'), Codeception uses defaults of 'report.xml' and 'report.html'.

If a valued option is passed (i.e. '--xml=my-custom-path/report.xml' or '--html=my-custom-path/report.html'), then this is used instead.

This MR just brings this possibility into GrumPHP

@veewee
Copy link
Contributor

veewee commented Apr 11, 2024

Thanks for the PR @petrisorciprian-vitals

So if I understand this option correctly, there are 3 ways to use these options?

  • no option : no report
  • --xml: Stores the report by default at report.xml
  • --xml=path: The path where you want to store te report.

Would it make sense to find a way to support all 3 options in here as well, that can be used in a Backwards Compatible way from a grumphp configuration point of view?

I'm thinking:

Keep bool|string as supported types, where:

  • false would result in no argument (no report)
  • true would result in --xml
  • string would result in a custom XML path: --xml=path

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants