Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallet_address to scopes #307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion SDK_reference.md

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK_reference.md

Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ type AuthResult = {

### `scopes`
Copy link

@wasi4440 wasi4440 Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • # -
Suggested change
### `scopes`
### `scopes`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no s que hacer

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK_reference.md@

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CryptoGing-WalletAddress

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eakode111

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible


Available scopes: `username`, `payments`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasi4440

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User name - SaNaMoe

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eakode111

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

Available scopes: `username`, `payments`, `wallet_address`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SaNaMoe

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GACJXMWK23KTJJISEYHUF47OU5OFKFHVJV2KZZRTQJRNCOYU7MDJMWPP

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GBCT2ZKP3GAITRA4XQH5C4ICCJWKF3GGPXU2Q7JFN7T3LXCN4C4ELKNV

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GBFTP3KV6NXMECJ66XKT6FDWCXSLPKO4EY4FG2GOKSGY6NPHBWQQVUYB

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My wallet address -GBCT2ZKP3GAITRA4XQH5C4ICCJWKF3GGPXU2Q7JFN7T3LXCN4C4ELKNV

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GBZO3OKL5CLSCSPDH76DYQUB7OPONOB3WUVN55GDC654CCA7F5P3A47S

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GDCCFRHQAL4PQQRZP4G4CFSKFD63V5LPZY4CKMX3F4A6XDCOFQTJEVWB


> **Not yet implemented**
>
Expand All @@ -67,6 +67,7 @@ Available scopes: `username`, `payments`.
> However, you should implement your app by only adding the scopes you need when calling `authenticate`.
> Scopes support will be added before the general release of the Pi platform.

<br />
Here is a breakdown of various keys available on the `AuthResult['user']` object, and the scopes required for those keys
to be present:

Expand All @@ -75,6 +76,16 @@ to be present:
| `uid` | An app-local identifier for the user. This is specific to this user, and this app. It will change if the user revokes the permissions they granted to your app. | (none) |
| `username` | The user's Pi username. | `username` |

<br />

Here is a breakdown of scopes with no return and methods requiring them:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SaNaMoe e

| Scope | Description | Methods Requiring Scope |
| -------------: | ------------- | :-------------: |
| `payments` | Gives permission to the app to create payments on the users behalf | `createPayment` |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GBZO3OKL5CLSCSPDH76DYQUB7OPONOB3WUVN55GDC654CCA7F5P3A47S

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aptove

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

| `wallet_address` | Gives the app access to the users public wallet address | `createPayment` - App to User Payments|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GBCT2ZKP3GAITRA4XQH5C4ICCJWKF3GGPXU2Q7JFN7T3LXCN4C4ELKNV

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GBFTP3KV6NXMECJ66XKT6FDWCXSLPKO4EY4FG2GOKSGY6NPHBWQQVUYB

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GBZO3OKL5CLSCSPDH76DYQUB7OPONOB3WUVN55GDC654CCA7F5P3A47S


<br />
### `onIncompletePaymentFound`

Signature: `(payment: PaymentDTO) => void`
Expand Down