if skipgravityonboot set, check db version.

[edgd1er]

during pihole -g version is checked and db updated if needed.

Description

At boot time either run pihole -g or check and upgrade database structure if needed.

Motivation and Context

Updating everyday or at every start lists may be of little use and harsh on lists servers.
Allowing to bypass update at boot time, speed up the start and avoid traffic on lists servers.
Some lists are on github servers, too many accesses may trigger ban rules.

Fix #1398

When SKIPGRAVITYONBOOT is not set (default), pihole -g runs at boot time.
it checks database's version and upgrade it if needed.

SKIPGRAVITYONBOOT allows to bypass the "pihole -g" step, hence database version is not checked anymore, lists are not updated.
Depending on the last update, incorrect version will cause many errors in the admin website.

How Has This Been Tested?

I copied v5 databases to v6 container's volumes, an checked that database structure was updated and lists were not.

docker-pi-hole-pihole-1  | + gravityDBfile=/etc/pihole/gravity.db
docker-pi-hole-pihole-1  | + '[' -n true ']'
docker-pi-hole-pihole-1  | + '[' -f /etc/pihole/gravity.db 
docker-pi-hole-pihole-1  | ']'
docker-pi-hole-pihole-1  |   Skipping Gravity Database Update.
docker-pi-hole-pihole-1  | + echo '  Skipping Gravity Database Update.'
docker-pi-hole-pihole-1  | + source /opt/pihole/utils.sh
docker-pi-hole-pihole-1  | + source /etc/.pihole/advanced/Scripts/database_migration/gravity-db.sh
docker-pi-hole-pihole-1  | ++ readonly scriptPath=/etc/.pihole/advanced/Scripts/database_migration/gravity
docker-pi-hole-pihole-1  | ++ scriptPath=/etc/.pihole/advanced/Scripts/database_migration/gravity
docker-pi-hole-pihole-1  | + upgrade_gravityDB /etc/pihole/gravity.db /etc/pihole
docker-pi-hole-pihole-1  | + local database 
docker-pi-hole-pihole-1  | piholeDir 
docker-pi-hole-pihole-1  | auditFile version
docker-pi-hole-pihole-1  | + database=/etc/pihole/gravity.db
docker-pi-hole-pihole-1  | + 
docker-pi-hole-pihole-1  | piholeDir=/etc/pihole
docker-pi-hole-pihole-1  | + auditFile=/etc/pihole/auditlog.list
docker-pi-hole-pihole-1  | ++ pihole-FTL sqlite3 /etc/pihole/gravity.db 'SELECT "value" FROM "info" WHERE "property" = '\''version'\'';'
docker-pi-hole-pihole-1  | + version=16
docker-pi-hole-pihole-1  | + [[ 16 == \1 ]]
docker-pi-hole-pihole-1  | + [[ 16
docker-pi-hole-pihole-1  |  == 
docker-pi-hole-pihole-1  | \2 ]]
docker-pi-hole-pihole-1  | + [[ 
docker-pi-hole-pihole-1  | 16 == \3 ]]
docker-pi-hole-pihole-1  | + [[ 16 == \4 ]]
docker-pi-hole-pihole-1  | + 
docker-pi-hole-pihole-1  | [[ 16
docker-pi-hole-pihole-1  |  == 
docker-pi-hole-pihole-1  | \5 ]]
docker-pi-hole-pihole-1  | + [[ 16 == \6 ]]
docker-pi-hole-pihole-1  | + [[ 16 == \7 ]]
docker-pi-hole-pihole-1  | + [[ 16 == \8 ]]
docker-pi-hole-pihole-1  | + [[ 16 == \9 ]]
docker-pi-hole-pihole-1  | + [[ 16 == \1\0 ]]
docker-pi-hole-pihole-1  | + [[ 16 == \1\1 ]]
docker-pi-hole-pihole-1  | + [[ 16 == \1\2 ]]
docker-pi-hole-pihole-1  | + [[ 16 == \1\3 ]]
docker-pi-hole-pihole-1  | + [[ 16 == \1\4 ]]
docker-pi-hole-pihole-1  | + [[ 16 == \1\5 ]]

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[PromoFaux]

Thanks, I'll take a look at this later on. In the meantime, could you rebase on development-v6 and maybe look at adding some tests for this section of code? Not sure about testing the db upgrade part, but the other parts should be testable

[PromoFaux]

@edgd1er , looks like you rebased on the wrong branch :)

[PromoFaux]

I have now merged the UID/GID branch in, so please rebase on development-v6 once more (I can do this for you if you need help!)

[edgd1er]

I have now merged the UID/GID branch in, so please rebase on development-v6 once more (I can do this for you if you need help!)

I've rebased and signed off. it should be ok, now

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information