New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify delimter for array type FTLCONF_ values #1464

Merged

PromoFaux merged 1 commit into development-v6 from v6/tweak_delimiter

Oct 29, 2023

Member

PromoFaux commented Oct 29, 2023

What does this PR aim to accomplish?:

pi-hole/FTL#1707 set the delimiter for all array type configs as ; (a change from , or ;), this PR clarifies that.

Merge this after the following action has completed it's work: https://github.com/pi-hole/FTL/actions/runs/6684895355

By submitting this pull request, I confirm the following:

I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
I have commented my proposed changes within the code and I have tested my changes.
I am willing to help maintain this change if there are issues with it later.
It is compatible with the EUPL 1.2 license
I have squashed any insignificant commits. (git rebase)

I have read the above and my PR is ready for review. Check this box to confirm


          Clarify delimter for array type FTLCONF_ values

9928cfa

Signed-off-by: Adam Warner <[email protected]>

PromoFaux requested a review from a team

October 29, 2023 17:50

PromoFaux merged commit 230e14e into development-v6

7 checks passed

PromoFaux deleted the v6/tweak_delimiter branch

October 29, 2023 18:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet