Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idn2-utils to image as it is needed for pihole -q #1465

Closed
wants to merge 1 commit into from

Conversation

yubiuser
Copy link
Member

As the title says. Fixes a bug reported here:
#1577

@yubiuser yubiuser requested a review from a team October 29, 2023 19:29
@DL6ER
Copy link
Member

DL6ER commented Oct 29, 2023

Is idn2 still used by pihole -q even when it queries FTL's API? We could easily expose FTL's own idn capabilities over the API if needed.

@yubiuser
Copy link
Member Author

@yubiuser
Copy link
Member Author

Last commit should fix changes required after pi-hole/FTL#1707

@PromoFaux
Copy link
Member

@yubiuser rebase on development-v6, I've admin-crimed your latest commit there.

@PromoFaux
Copy link
Member

Could (thinking out loud here) FTL handle the part of converting the ${domain} value it is passed to punycode and lowercase itself?

@DL6ER
Copy link
Member

DL6ER commented Oct 30, 2023

@PromoFaux Like pi-hole/FTL#1715 ?

@PromoFaux
Copy link
Member

Like this. So with that PR, we would still need to convert to lower case in the bash, right?

@PromoFaux
Copy link
Member

No scratch that, Not had my coffee - I misread your typings

@yubiuser
Copy link
Member Author

Closing as pi-hole/FTL#1715 works as expected.

idn2 is not required anymore: pi-hole/pi-hole#5468

@yubiuser yubiuser closed this Oct 31, 2023
@yubiuser yubiuser deleted the idn2 branch October 31, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants