Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop the /v8 from linux/arm64/v8 #1468

Merged
merged 1 commit into from
Oct 30, 2023
Merged

drop the /v8 from linux/arm64/v8 #1468

merged 1 commit into from
Oct 30, 2023

Conversation

PromoFaux
Copy link
Member

@PromoFaux PromoFaux commented Oct 30, 2023

What does this PR aim to accomplish?:

CI is using linux/arm64/v8 in the platform matrix, we should be using linux/arm64. I think. Lets see what the tests say...


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux changed the title Just using the CI drop the /v8 from linux/arm64/v8 Oct 30, 2023
@PromoFaux
Copy link
Member Author

Looks good so far:

image

@PromoFaux
Copy link
Member Author

Ready for review

@yubiuser
Copy link
Member

I wonder if we now still need both TARGETPLATFORM set from 5c7ff5c

(I get always confused by the nested docker build on top of docker builds)

@PromoFaux
Copy link
Member Author

That was what my deleted comment was about.. I tried to build locally with that removed (run as PLATFORM=linux/arm64/v8 ./build-and-test.sh and the result was the following:

image

So that part is still needed I believe.

@PromoFaux
Copy link
Member Author

PromoFaux commented Oct 30, 2023

Both --platform=linux/arm64 and --platform=linux/arm64/v8 are valid and will produce a linux/arm64 image (per the link you shared earlier

The docker-in-docker stuff probably adds some complexity, and something we should look at finding another way around one day. But not this day. For now we can just use the simple form of the platform argument

Edit: And it's all part of the fun and games of having an open beta. More eyes to catch this stuff!

@PromoFaux PromoFaux merged commit 5b7fd46 into development-v6 Oct 30, 2023
8 checks passed
@PromoFaux PromoFaux deleted the v6/tweak-tests branch October 30, 2023 22:08
@PromoFaux
Copy link
Member Author

PromoFaux commented Oct 30, 2023

Watching the next publish like a hawk...

Edit:

All good
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants