Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloudflared.md #1066

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Update cloudflared.md #1066

merged 4 commits into from
Oct 21, 2024

Conversation

DiskCrasher
Copy link
Contributor

Changed DoH IP addresses to DNS lookups and added new information.

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Main change was replacing IP addresses with DNS endpoints.

How does this PR accomplish the above?:

Updated documentation to reflect.

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Changed DoH IP addresses to DNS lookups and added new information.

Signed-off-by: Mike <[email protected]>
Copy link

netlify bot commented Jun 30, 2024

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit fe96d8e
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/67156463c0b23400088493ac
😎 Deploy Preview https://deploy-preview-1066--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Fixed MD error.

Signed-off-by: Mike <[email protected]>
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@DiskCrasher
Copy link
Contributor Author

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Maybe because you waited four months before you considered merging it? What's the point?

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. We are a small team of volunteers doing Pi-hole in our free time next to family, full-time work and other duties. Additionally, we are right in the middle of releasing the next major version.

I only have a small request on your PR.

docs/guides/dns/cloudflared.md Outdated Show resolved Hide resolved
Copy link
Contributor

Conflicts have been resolved.

@yubiuser yubiuser merged commit e5433bf into pi-hole:master Oct 21, 2024
8 checks passed
@DiskCrasher DiskCrasher deleted the patch-1 branch October 21, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants