Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword arg to select font to miniscreen display text methods #391

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

angusjfw
Copy link
Contributor

@angusjfw angusjfw commented Jul 14, 2021

My use case is to display emojis for a memory game.

It's unfortunate that Pillow ImageFont does not support combining fonts, so that fallback fonts could be automatically used for characters not in the default. One possibility would be for us to create and use font with the combinations manually. This font option would allow a user to do so themselves at least.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #391 (0cb5c72) into master (5a7269f) will decrease coverage by 0.06%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   54.58%   54.51%   -0.07%     
==========================================
  Files          80       80              
  Lines        3261     3265       +4     
==========================================
  Hits         1780     1780              
- Misses       1481     1485       +4     
Flag Coverage Δ
unittests 54.51% <33.33%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pitop/miniscreen/oled/oled.py 32.93% <33.33%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a7269f...0cb5c72. Read the comment docs.

@m-roberts m-roberts merged commit 74a8eeb into master Jul 22, 2021
@m-roberts m-roberts deleted the miniscreen_text_font_option branch July 22, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants