Use standard golang.org/x/tools/go/callgraph package
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates (by outright removing) the non-standard
github.com/picatz/taint/callgraphpackage in favor of using the standardgolang.org/x/tools/go/callgraphpackage.To keep the same functionality (like graph construction and path searching) provided by the previous
callgraphpackage, agithub.com/picatz/taint/callgraphutilspackage has been created which operates ongolang.org/x/tools/go/callgraph.Graphtypes.Importantly, this allows for seamless "apples to apples" comparisons with other call graph construction algorithms (CHA, RTA, VTA, Static, Pointer), or even those provided by projects like
govulncheck.Today, I believe the graph constructed by
github.com/picatz/taint/callgraphutils.NewGraphprovides the best foundation for taint analysis. I look forward to progress in this space in the near future to handle complex edges (#23) not easily handled by today's algorithm(s).