Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Litestar template to use create_pydantic_model #859

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

sinisaos
Copy link
Member

@sinisaos sinisaos commented Jul 7, 2023

Related to #858. I also pinned Pydantic to version 1.10.11 which is the last version before V2 because we are not ready for Pydantic V2 yet.

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Merging #859 (a70a90c) into master (36e80f5) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #859   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         109      109           
  Lines        7887     7887           
=======================================
  Hits         7227     7227           
  Misses        660      660           
Impacted Files Coverage Δ
piccolo/apps/asgi/commands/new.py 73.43% <ø> (ø)

@dantownsend
Copy link
Member

Damn, the integration tests are failing now ...

I think I need to release the latest Piccolo Admin and Piccolo API first.

@dantownsend dantownsend merged commit fb3c8eb into piccolo-orm:master Jul 7, 2023
46 checks passed
@sinisaos sinisaos deleted the update_litestar_template branch July 8, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants