Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit graphlib from test coverage #874

Merged

Conversation

sinisaos
Copy link
Member

Related to #873

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #874 (f0b5372) into master (b13c383) will increase coverage by 1.19%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
+ Coverage   90.91%   92.11%   +1.19%     
==========================================
  Files         109      107       -2     
  Lines        8214     8105     -109     
==========================================
- Hits         7468     7466       -2     
+ Misses        746      639     -107     

see 2 files with indirect coverage changes

@dantownsend
Copy link
Member

dantownsend commented Jul 28, 2023

Makes sense - thanks!

@dantownsend dantownsend merged commit 83ea663 into piccolo-orm:master Jul 28, 2023
37 checks passed
@sinisaos sinisaos deleted the remove_graphlib_from_coverage branch July 28, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants