Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ASGI requirements #911

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Update ASGI requirements #911

merged 5 commits into from
Jan 23, 2024

Commits on Dec 12, 2023

  1. remove jinja2 

    Piccolo has `jinja2` as a direct dependency, so this shouldn't be needed.
    @dantownsend
    dantownsend committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d7d054c View commit details
    Browse the repository at this point in the history

  2. remove requeste 

    I think this was needed for Starlette at some point, but it has since transitioned to `httpx`, so I don't think it's needed any more.
    @dantownsend
    dantownsend committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    985513c View commit details
    Browse the repository at this point in the history

  3. move piccolo_admin to ROUTER_DEPENDENCIES 

    We don't use it for `esmerald` so don't include it by default for all routers.
    @dantownsend
    dantownsend committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    3d9b881 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. no longer omit piccolo_admin for esmerald

    @dantownsend
    dantownsend committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f06384d View commit details
    Browse the repository at this point in the history

  2. add piccolo_admin to _esmerald_app.py.jinja

    @dantownsend
    dantownsend committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c0d6413 View commit details
    Browse the repository at this point in the history