Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User mapping for Merge Requests #104

Open
mike-potter opened this issue Oct 7, 2021 · 8 comments · May be fixed by #186
Open

User mapping for Merge Requests #104

mike-potter opened this issue Oct 7, 2021 · 8 comments · May be fixed by #186

Comments

@mike-potter
Copy link

I have filled out the user mapping table between GitLab and GitHub usernames. However, when I migrate the MRs->PRs the owner of the PR in Github is always my own user and not the user from GitLab. Is there a way to fix that?

@mdbenito
Copy link
Contributor

mdbenito commented Dec 3, 2021

Not really. The GH api sets the owner to the one making the request. The only way is to make requests as the different users (with different tokens) or to use an impersonation token, as available on GH Enterprise. This script does not allow for that (yet)

@spruce
Copy link
Member

spruce commented Jan 10, 2022

@mike-potter with the new setting useIssueImportAPI it may be possible. @mdbenito did you test that?

@mdbenito
Copy link
Contributor

Sadly, the issue import API does not allow setting the creator of an issue. The only solutions I know of are the two I listed (and I'm not sure about how the impersonation token would work)

@XabierGoros
Copy link

Have you guys checked this?

@mdbenito
Copy link
Contributor

That would be a very useful contribution! Can we expect a PR? 😃

@XabierGoros
Copy link

Not my changes, all credits are for @valentinschabschneider from his repo. He should definitely be contacted. I personally tested those changes with great success.

pelme added a commit to pelme/node-gitlab-2-github that referenced this issue Jul 5, 2023
@pelme pelme linked a pull request Jul 5, 2023 that will close this issue
@valentinschabschneider
Copy link

@XabierGoros totally forgot about that repo 😅

Cool to see that @pelme is now implementing it properly 🎉

@pelme
Copy link

pelme commented Jul 6, 2023

@valentinschabschneider I assume you already migrated your repos but a quick code review from you would be very helpful.🙏

There were a handful of merge conflicts to deal with, I hope I didn’t screw anything up 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants